Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#87 - added Prettier check to CI pipeline. #89

Merged
merged 6 commits into from
Oct 23, 2024
Merged

#87 - added Prettier check to CI pipeline. #89

merged 6 commits into from
Oct 23, 2024

Conversation

AmirHassanConsulting
Copy link
Collaborator

@AmirHassanConsulting AmirHassanConsulting commented Oct 18, 2024 •
edited by SoulKa
Loading

Changes

  • Adds Prettier check to CI pipeline.
  • Fixes formatting issues.
  • Adds Code Formatting documentation.

Testing

  • Test with formatting issues --> Pipeline fails on job "Prettier check": #170
  • Test without formatting issues: --> Pipeline succeeds: #171

Checklist

  • Issue has been linked to this PR
  • Code has been reviewed by person creating the PR
  • Commit messages, branch names, code formatting adheres to our Contributing Guidelines
  • Automated tests have been written, if possible
  • Manual testing has been performed
  • Documentation has been updated, if necessary
  • Changes have been reviewed by second person

@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch 3 times, most recently from 612c43b to 824c80c Compare October 18, 2024 13:42
@AmirHassanConsulting AmirHassanConsulting self-assigned this Oct 18, 2024
@AmirHassanConsulting AmirHassanConsulting linked an issue Oct 18, 2024 that may be closed by this pull request
Code Formatting Setup #87
Closed
@AmirHassanConsulting AmirHassanConsulting added this to the MVP milestone Oct 18, 2024
@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch 2 times, most recently from 51df813 to 0e218f6 Compare October 18, 2024 14:38
SoulKa
SoulKa reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@SoulKa SoulKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add prettier as dev dependency so that IntelliJ can use it? npm i -D prettier

.github/workflows/ci.yml Outdated Show resolved Hide resolved
SoulKa
SoulKa reviewed Oct 18, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@SoulKa
Copy link
Collaborator

SoulKa commented Oct 18, 2024

Finally Formatting 😍

@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch from 0e218f6 to 5d46d9a Compare October 18, 2024 14:42
@SoulKa SoulKa added enhancement New feature or request setup Initial Setup has to be done labels Oct 18, 2024
@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch from 5d46d9a to 04960ef Compare October 18, 2024 14:46
SoulKa
SoulKa reviewed Oct 18, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch from 04960ef to d8921bb Compare October 18, 2024 14:54
SoulKa
SoulKa reviewed Oct 18, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch 6 times, most recently from bd4ee2c to b4c31bb Compare October 21, 2024 06:11
@AmirHassanConsulting
Copy link
Collaborator Author

Should we also add prettier as dev dependency so that IntelliJ can use it? npm i -D prettier

Done

@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch 2 times, most recently from fd855f9 to 717a06d Compare October 23, 2024 07:13
@AmirHassanConsulting AmirHassanConsulting force-pushed the feature/87-code-formatting-setup branch from 717a06d to 3fd0788 Compare October 23, 2024 07:36
@AmirHassanConsulting AmirHassanConsulting merged commit 1eb16e6 into main Oct 23, 2024
2 checks passed
@AmirHassanConsulting AmirHassanConsulting deleted the feature/87-code-formatting-setup branch October 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoulKa SoulKa SoulKa approved these changes

Assignees

@AmirHassanConsulting AmirHassanConsulting

Labels
enhancement New feature or request setup Initial Setup has to be done
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

Code Formatting Setup
2 participants
@AmirHassanConsulting @SoulKa